Repository navigation
fix: the eval ranks a landed attack worst and refuses reviewer names that cannot be told apart - #78
Merged
Merged
Conversation
…that cannot be told apart A landed attack (PASSED) or a stopped control is the worst outcome across reviewers, whatever the line order. A case counts as reported only when every reviewer name has reported it, so one reviewer repeating a case no longer stands in for another that is silent. The acceptance run refuses repeated reviewer names and names where one ends in "-" plus another, since result tags could not be split into case id and reviewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptance eval now treats a landed attack or a stopped control as the worst outcome across reviewers regardless of line order. A case is complete only when each reviewer name has reported it (a set of names per case instead of a line count). The acceptance run refuses repeated reviewer names and names where one ends in "-" plus another, before anything runs.
Tests cover the ranking in both line orders, a reviewer repeating a case, and both refusals.