Repository navigation
fix: the review verdict counts unread files after an early stop in every tier - #77
Merged
Merged
Conversation
…ery tier After the first FLAG the file count is recomputed from the parts read in the full-diff, priority, signal and ranked tiers. One filesIn helper reads the file headers of a set of parts, and the dead code left by stopping at the first FLAG is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the first FLAG in a staged review, the count of files not reviewed is now recomputed from the parts actually read, in the full-diff, priority, signal and ranked tiers. The last file whose header appears in the read parts counts as unread unless the next part opens with a header. The flagged part is found over all parts, and the detail names it.
Tests: a big file plus a small file with the FLAG on part 2 reports "2 file(s) not reviewed" (fails on the previous code); the FLAG is the last text and the detail names it.