Repository navigation
fix: read a large release in full, stage by stage, before holding it as too large - #76
Merged
Merged
Conversation
…as too large A diff that needs more reviewer parts than maxParts is now reviewed in stages of maxParts parts, up to maxParts * maxStages parts (default 12 * 6), instead of being narrowed to priority files and held. The first FLAG stops the review and the verdict text counts the parts actually read. Past the ceiling the existing tiers (priority, signal, ranked) and their holds are unchanged; maxStages 1 gives the old single-stage budget. A missing, non-finite or sub-1 count falls back to the default. The image layer review gets the same staging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release whose diff needs more reviewer parts than the budget used to be narrowed to priority files and held for a human as "too large for model review". It is now read in full, in stages of maxParts parts, up to maxParts * maxStages parts (default 12 * 6 = 72). The first FLAG stops the review, and the verdict text counts the parts actually read. Past the ceiling the existing tiers and holds are unchanged; maxStages 1 gives the old single-stage budget. A missing, non-finite or sub-1 count falls back to the default (a maxParts of 0 no longer means "read nothing"). The image layer review gets the same staging.
Trade-offs: releases of 13 to 72 parts that were held can now land on per-part approvals, each part judged alone, and an all-clean release costs up to six times the serial model calls. Evaluation numbers that depended on the old 12-part narrowing will shift.
Tests cover the budget edges, a bad part in each tier, the first-FLAG stop and its counts, stages carrying into a later FLAG, the image path at the default budget, and the count guard.