Repository navigation
fix: track assignments through functions, prefix words, quoted names and loops in the shell scan - #75
Merged
Merged
Conversation
…and loops in the shell scan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes more cases where the install-script scan lost track of a variable: function bodies that run a name set outside them, time/!/-p prefix words (including dash, which has no time keyword), quoted or escaped assignment names, loop second pass names, arithmetic assignment places, and tilde/path forms after compiler flags. Each class has tests that fail without the change.