Repository navigation
fix: install-script parsing reads every line it can when one line does not parse - #69
Merged
Merged
Conversation
…s not parse A line the reader could not parse used to stop the scan of the whole install script. The scan now reads the lines it can, widens for the part it cannot read, and keeps the cost linear on long lines. Adds tests for quoting, substitutions, heredocs, loader variables and an unchanged package staying quiet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A correctness fix to install-script parsing. A line the reader could not parse used to stop the scan of the whole install script. The scan now reads the lines it can, widens for the part it cannot read, and keeps the cost linear on long lines.
Adds tests for quoting, substitutions, heredocs, loader variables and an unchanged package staying quiet. Full suite and type check pass.