fix(network): conform DNS resolver to aiohttp ResolveResult typing - #5
Merged
Merged
Conversation
The remaining Copilot-review-adjacent items in the resolver, all from the original wiring: `_PinnedResolver.resolve` returned `list[dict[str, Any]]` where aiohttp's `AbstractResolver.resolve` requires `List[ResolveResult]`, and `_resolve_host` built a `tuple[str | int, AddressFamily]` dedup key that didn't match its `set[tuple[str, int]]`. - Import `AbstractResolver`/`ResolveResult` from `aiohttp.abc` and subclass `AbstractResolver` directly (clears the `aiohttp.abc` attribute-access warning and lets pyright actually check the override). - Type `_resolve_host`, `check_allowed`, and `_PinnedResolver` records/return as `ResolveResult` (the record dicts already carry exactly its keys). - Coerce `sockaddr[0]` to `str` so the dedup key is `tuple[str, AddressFamily]`. pyright: 0 errors/0 warnings on the module. Behavior unchanged; 2297 tests pass incl. all private-range/rebinding tests.
ajram23
pushed a commit
that referenced
this pull request
Aug 11, 2026
Wire NetworkConfig through Bash + curl + interpreter (closes #5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the Copilot-review cleanup of the ported resolver code (same
bbb2f27wiring)._PinnedResolver.resolvereturnedlist[dict[str, Any]]but aiohttp'sAbstractResolver.resolverequiresList[ResolveResult];_resolve_host's dedup key wastuple[str | int, AddressFamily]vs itsset[tuple[str, int]]. Now importsAbstractResolver/ResolveResultfromaiohttp.abc, types the record flow asResolveResult, and coercessockaddr[0]tostr. pyright: 0 errors; behavior unchanged; 2297 tests pass (incl. private-range/rebinding).