ci: gate network tests (run tests/test_network.py in CI) - #3
Merged
Conversation
CI ran only `tests/test_commands/`, so `tests/test_network.py` (the network/curl integration suite, including the curl compression regression tests) was never executed by the Test or Release workflows — a transport regression could merge or ship green. Add `tests/test_network.py` to both pytest invocations so the network suite is gated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both workflows run only
pytest tests/test_commands/, whilepyproject.tomlsetstestpaths = ["tests"]. The explicit path arg overridestestpaths, so CI silently skipstests/test_network.py— the entire network/curl integration suite (allow-list, redirects, private-range blocking, header transforms, and the curl compression regression tests). A transport regression (e.g. re-introducing the gzip Accept-Encoding bug) would merge and ship green.This gap has existed since
tests/test_network.pywas added without updating the workflows.Fix
Append
tests/test_network.pyto the pytest invocation intest.ymlandrelease.yml:Verification
pytest tests/test_commands/ tests/test_network.py→ 2297 passed, 1 skipped locally. (Other un-gated suites likespec_tests/are intentionally left out — they're a partial-compliance corpus that fails ~50% by design.)