Skip to content

Initial support for using range.getClientRects to measure text.#5922

Open
nightwing wants to merge 15 commits intomasterfrom
varchar3
Open

Initial support for using range.getClientRects to measure text.#5922
nightwing wants to merge 15 commits intomasterfrom
varchar3

Conversation

@nightwing
Copy link
Copy Markdown
Member

@nightwing nightwing commented Feb 22, 2026 •
edited by github-actions Bot
Loading

xyos
xyos reviewed Feb 25, 2026
View reviewed changes
Comment thread src/layer/font_metrics.js Outdated
Comment thread src/layer/font_metrics.js Outdated
Comment thread src/virtual_renderer.js
Comment thread src/layer/font_metrics.js Outdated
Comment thread src/layer/font_metrics.js Outdated
Comment thread src/layer/font_metrics.js Outdated
Comment thread src/layer/font_metrics.js
Comment thread src/layer/font_metrics.js Outdated
Comment thread src/layer/font_metrics.js Outdated
xyos
xyos reviewed Feb 25, 2026
View reviewed changes
Comment thread src/layer/font_metrics.js
xyos
xyos reviewed Feb 25, 2026
View reviewed changes
Comment thread src/layer/font_metrics.js Outdated
xyos
xyos approved these changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xyos xyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nightwing nightwing mentioned this pull request Apr 27, 2026
Open
@nightwing nightwing force-pushed the varchar3 branch 3 times, most recently from c7be8dd to 90b4eee Compare May 2, 2026 08:37
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.11754% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.93%. Comparing base (c89c0d5) to head (6138c2d).

Files with missing lines Patch % Lines
src/layer/font_metrics.js 93.60% 33 Missing ⚠️
src/test/mockdom.js 92.83% 20 Missing ⚠️
src/layer/marker.js 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5922      +/-   ##
==========================================
+ Coverage   93.73%   93.93%   +0.20%     
==========================================
  Files         640      640              
  Lines      137743   138436     +693     
  Branches    14487    14706     +219     
==========================================
+ Hits       129113   130043     +930     
+ Misses       8630     8393     -237
Flag Coverage Δ
unittests 93.93% <95.11%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xyos xyos xyos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nightwing @xyos @mkslanc