Repository navigation
Add DB schema regression tests - #675
Merged
Merged
Conversation
Owner
|
Looks nice. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #672.
Adds an instrumentation regression test for database schema drift.
The test covers:
SQLiteOpenHelperand checking that each current table contains every column used by its table adapter.Dbupgrade path, and checking the same contracts afterwards.The expected columns are derived from the existing table adapters'
toContentValues()implementations rather than maintaining a separate copy of the current schema.The test uses isolated temporary databases and mocks
isFreshInstall()so it does not modify the app database or create notification channels.The v4.20 fixture is intended to remain unchanged while that release is inside the supported upgrade window, then be replaced by a newer release baseline when the compatibility window advances.
No production-code changes or new dependencies.
Validation performed before opening this PR:
masterI have not run the Android instrumentation test on a real/emulated Android device in my environment.