You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks good! Only thing I am unsure about is the names. Why did you choose "fit"?
Also, I never really got why we chose _config with underscore, now that you named the other folder _core_op. The files within _config also start with underscore while the ones in _core_op don't. I suggest removing the underscores or at least be fully consistent.
Looks good! Only thing I am unsure about is the names. Why did you choose "fit"? Also, I never really got why we chose _config with underscore, now that you named the other folder _core_op. The files within _config also start with underscore while the ones in _core_op don't. I suggest removing the underscores or at least be fully consistent.
@viktorbeck98 I renamed the files following previous standard. About the "fit", is because I could not came up with another word that combines the configuration and the training.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.