Skip to content

Docs impl#53

Merged
whotwagner merged 37 commits intodevelopmentfrom
docs_impl
Feb 25, 2026
Merged

Docs impl#53
whotwagner merged 37 commits intodevelopmentfrom
docs_impl

Conversation

@ipmach
Copy link
Contributor

@ipmach ipmach commented Feb 11, 2026

Add documentation to DetectMate.

@ipmach ipmach added enhancement New feature or request New feature labels Feb 11, 2026
@viktorbeck98
Copy link
Collaborator

ready to merge? @ipmach

@viktorbeck98
Copy link
Collaborator

There's multiple speeling issues, pls correct them or ask copilot to resolve them @ipmach

@ipmach
Copy link
Contributor Author

ipmach commented Feb 12, 2026

There's multiple speeling issues, pls correct them or ask copilot to resolve them @ipmach

yeah I know, this is currently a draft PR. It is not ready for review

@ipmach
Copy link
Contributor Author

ipmach commented Feb 17, 2026

Ok, now the branch is ready to review. However:

  • We need to find a way to make sure that the code examples always work without too many manual work (the docs will increase in the future).
  • The pages "Basic usage" and "implement new component" are missing.

@ipmach ipmach marked this pull request as ready for review February 17, 2026 14:24
- name: Test with pytest
run: uv run --dev pytest -s

# include following code into the run section to match DetectMateService and DetectMateLibrary branches, if the name matches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be removed. This section determines which version of the DetectMateService should be pulled in for testing. If you are on main, it sets the service branch to main. Otherwise, it defaults to development.

Co-authored-by: whotwagner <code@feedyourhead.at>
@ipmach
Copy link
Contributor Author

ipmach commented Feb 24, 2026

Ok, I think all comments have being address and we can merge the branch. Otherwise let me know :)

- Install dev dependencies (testing, linters, formatters):

```bash
uv pip install -e .[dev]
Copy link
Contributor

@thorinaboenke thorinaboenke Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uv pip install -e .[dev]
uv sync --dev

both create a working development environment, but uv pip install only adds packages to the existing state, uv sync --dev will automatically automatically sync the environment with the lockfile

Copy link
Contributor

@thorinaboenke thorinaboenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs!
please use uv sync --dev with a uv.lock file instead of uv pip install -e .[dev] (sry, did notice in my last review!)
and ensure pytest in python-app.yml matches library and service branches (or reason the changes, maybe I missed something?)

@ipmach
Copy link
Contributor Author

ipmach commented Feb 24, 2026

Nice docs! please use uv sync --dev with a uv.lock file instead of uv pip install -e .[dev] (sry, did notice in my last review!) and ensure pytest in python-app.yml matches library and service branches (or reason the changes, maybe I missed something?)

Thanks! I updated the manual for the uv sync --dev part. I also modify the pytest command so is identical to the one use in the python-app.yml.

@whotwagner whotwagner merged commit 93b356a into development Feb 25, 2026
1 check passed
@whotwagner whotwagner deleted the docs_impl branch February 25, 2026 10:31
@ipmach ipmach mentioned this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants