Conversation
|
ready to merge? @ipmach |
|
There's multiple speeling issues, pls correct them or ask copilot to resolve them @ipmach |
yeah I know, this is currently a draft PR. It is not ready for review |
|
Ok, now the branch is ready to review. However:
|
| - name: Test with pytest | ||
| run: uv run --dev pytest -s | ||
|
|
||
| # include following code into the run section to match DetectMateService and DetectMateLibrary branches, if the name matches. |
There was a problem hiding this comment.
this should not be removed. This section determines which version of the DetectMateService should be pulled in for testing. If you are on main, it sets the service branch to main. Otherwise, it defaults to development.
Co-authored-by: whotwagner <code@feedyourhead.at>
|
Ok, I think all comments have being address and we can merge the branch. Otherwise let me know :) |
docs/installation.md
Outdated
| - Install dev dependencies (testing, linters, formatters): | ||
|
|
||
| ```bash | ||
| uv pip install -e .[dev] |
There was a problem hiding this comment.
| uv pip install -e .[dev] | |
| uv sync --dev |
both create a working development environment, but uv pip install only adds packages to the existing state, uv sync --dev will automatically automatically sync the environment with the lockfile
There was a problem hiding this comment.
Nice docs!
please use uv sync --dev with a uv.lock file instead of uv pip install -e .[dev] (sry, did notice in my last review!)
and ensure pytest in python-app.yml matches library and service branches (or reason the changes, maybe I missed something?)
Thanks! I updated the manual for the uv sync --dev part. I also modify the pytest command so is identical to the one use in the python-app.yml. |
Add documentation to DetectMate.