Open
Conversation
To get this to work, we also need to move the code from src/ to its own package in memcache. This is because we're adding a complex example with axum, which includes its own Cargo.toml. This has other effects: it means that you can't add single file examples anymore. It must be a crate. This is the same decision used in the Axum repo, and is just a current limitation of cargo.
Owner
|
Adding examples is good, but I don't think it's a good reason to change the whole project structure. The axum project has multiple crates besides the example, so it is reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some new examples to the repo:
While trying to get this up and running, I was looking into how I could properly set up a connection pool. It required a little bit of digging, so I figured I may as well pitch in and add an example. I wanted to use it with Axum in particular, so I've also included an example for that too. Getting this setup required some shifts around the repo.
From my commit message:
see also: https://github.com/tokio-rs/axum/tree/main/examples