Skip to content

update deepmerge#26

Open
naoya7076 wants to merge 2 commits into
airbnb:masterfrom
naoya7076:fix-vulnerability
Open

update deepmerge#26
naoya7076 wants to merge 2 commits into
airbnb:masterfrom
naoya7076:fix-vulnerability

Conversation

@naoya7076

@naoya7076 naoya7076 commented Aug 28, 2020

Copy link
Copy Markdown

This package has been outdated. So I updated deepmerge to 3.3.0
I checked all test have passed.

Closes #27.

@naoya7076 naoya7076 mentioned this pull request Aug 28, 2020
Comment thread package.json
"dependencies": {
"airbnb-prop-types": "^2.10.0",
"brcast": "^2.0.2",
"deepmerge": "^1.5.2",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merely being outdated is not inherently bad; in this case, why not v4?

Reviewing the changelog suggests that the clone option now defaults to true, which might affect our usage, but otherwise it looks safe.

@micro-chipset

micro-chipset commented Sep 28, 2021

Copy link
Copy Markdown

@ljharb Please update deepmerge to 4.2.2 #28

@micro-chipset

Copy link
Copy Markdown

@naoya7076 Please update

@ljharb ljharb force-pushed the fix-vulnerability branch from 18d051a to 2a0dea4 Compare October 7, 2021 21:30
@ljharb

ljharb commented Oct 7, 2021

Copy link
Copy Markdown
Collaborator

The easy breaking changes are that v3 dropped ESM, and v4 dropped UMD - but v2 has some potentially significant breaking changes: https://github.com/TehShrike/deepmerge/blob/master/changelog.md#200 that will take time to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deepmerge is outdated

4 participants