Skip to content

Apply connection_timeout to passive connections - #212

Merged
pohmelie merged 5 commits into
aio-libs:masterfrom
Cycloctane:pasv_timeout
Sep 19, 2026
Merged

pohmelie merged 5 commits into
aio-libs:masterfrom
Cycloctane:pasv_timeout

Conversation

@Cycloctane

@Cycloctane Cycloctane commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

What do these changes do?

Client's connection_timeout option currently is only available when connecting control ports. This PR makes client also apply timeout settings when opening new passive (data) connections.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.95%. Comparing base (35b6b83) to head (e3885b1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   97.94%   97.95%           
=======================================
  Files           6        6           
  Lines        2095     2098    +3     
=======================================
+ Hits         2052     2055    +3     
  Misses         43       43           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cycloctane
Cycloctane marked this pull request as ready for review September 18, 2026 17:00
@greptile-apps

greptile-apps Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge.

Reviews (5) · Last reviewed commit: "use context manager for monkeypatch"

Comment thread tests/test_connection.py Outdated
@pohmelie
pohmelie merged commit b983147 into aio-libs:master Sep 19, 2026
10 checks passed
@Cycloctane
Cycloctane deleted the pasv_timeout branch September 20, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants