-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Make alert icons customizable via setAlertIcons function #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@ainsleydev/sveltekit-helper": minor | ||
| --- | ||
|
|
||
| Adding global icon mapping for Alert and Notice components via `setAlertIcons()`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 38 additions & 10 deletions
48
packages/sveltekit-helper/src/components/notifications/alertIcons.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,52 @@ | ||
| import { CircleCheck, CircleX, type Icon as IconType, Info, TriangleAlert } from '@lucide/svelte'; | ||
| import { CircleCheck, CircleX, Info, TriangleAlert } from '@lucide/svelte'; | ||
| import type { Component } from 'svelte'; | ||
| import { writable } from 'svelte/store'; | ||
|
|
||
| /** | ||
| * Notification type variants | ||
| * Notification type variants. | ||
| */ | ||
| type NotificationType = 'info' | 'warning' | 'success' | 'error'; | ||
| export type NotificationType = 'info' | 'warning' | 'success' | 'error'; | ||
|
|
||
| /** | ||
| * Icon configuration for notification types | ||
| * Icon configuration for a notification type. | ||
| */ | ||
| type IconDetail = { | ||
| icon: typeof IconType; | ||
| export type IconDetail = { | ||
| icon: Component; | ||
| colour: string; | ||
| }; | ||
|
|
||
| /** | ||
| * Icon mapping for notification types | ||
| */ | ||
| export const alertIcons: Record<NotificationType, IconDetail> = { | ||
| const defaultAlertIcons: Record<NotificationType, IconDetail> = { | ||
| info: { icon: Info, colour: 'var(--colour-semantic-info)' }, | ||
| success: { icon: CircleCheck, colour: 'var(--colour-semantic-success)' }, | ||
| warning: { icon: TriangleAlert, colour: 'var(--colour-semantic-warning)' }, | ||
| error: { icon: CircleX, colour: 'var(--colour-semantic-error)' }, | ||
| }; | ||
|
|
||
| /** | ||
| * Writable store holding the active icon map for all Alert and Notice components. | ||
| * Consumers can override individual or all entries via setAlertIcons(). | ||
| */ | ||
| export const alertIconStore = writable<Record<NotificationType, IconDetail>>(defaultAlertIcons); | ||
|
|
||
| /** | ||
| * Globally overrides icons for Alert and Notice components. | ||
| * Call this once in your root layout (e.g. +layout.svelte) to supply | ||
| * your own SVG components instead of the default Lucide icons. | ||
| * | ||
| * @example | ||
| * ```ts | ||
| * import { setAlertIcons } from '@ainsleydev/sveltekit-helper'; | ||
| * import InfoIcon from '$lib/icons/Info.svelte'; | ||
| * import SuccessIcon from '$lib/icons/Success.svelte'; | ||
| * | ||
| * setAlertIcons({ | ||
| * info: { icon: InfoIcon, colour: 'var(--colour-info)' }, | ||
| * success: { icon: SuccessIcon, colour: 'var(--colour-success)' }, | ||
| * }); | ||
| * ``` | ||
| * | ||
| * @param overrides - Partial map of notification types to icon configurations. | ||
| */ | ||
| export function setAlertIcons(overrides: Partial<Record<NotificationType, IconDetail>>): void { | ||
| alertIconStore.update((current) => ({ ...current, ...overrides })); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a SvelteKit app follows the new docstring and calls
setAlertIcons()from+layout.svelte, thiswritable(...)lives in module scope and is therefore shared by every SSR request handled by the same server process. Any request-specific branding or tenant override will leak into later responses until another request mutates the store again, so one user's alerts can render with another user's icons/colours. This configuration needs to be scoped per render tree (for example via props/context) rather than stored in a process-wide singleton.Useful? React with 👍 / 👎.