Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/target/dokploy/apply.go
Original file line number Diff line number Diff line change
Expand Up @@ -1839,7 +1839,7 @@ func ensureMappingBool(node *yaml.Node, key string, value bool) bool {
want = "true"
}
current := mappingValue(node, key)
if current != nil && current.Kind == yaml.ScalarNode && current.Value == want {
if current != nil && current.Kind == yaml.ScalarNode && current.Tag == "!!bool" && current.Value == want {
return false
}
setMappingNode(node, key, &yaml.Node{Kind: yaml.ScalarNode, Tag: "!!bool", Value: want})
Expand Down
30 changes: 30 additions & 0 deletions internal/target/dokploy/datamove_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,36 @@ volumes:
}
}

func TestAttachDokployNetworkAliasesRewritesQuotedExternalTrueToBool(t *testing.T) {
compose := `services:
db:
image: postgres:17-alpine
networks:
default: {}
dokploy-network:
aliases:
- db
networks:
dokploy-network:
external: "true"
`
out, err := attachDokployNetworkAliases(compose)
if err != nil {
t.Fatalf("attachDokployNetworkAliases: %v", err)
}
var doc yaml.Node
if err := yaml.Unmarshal([]byte(out), &doc); err != nil {
t.Fatalf("parse compose: %v\n%s", err, out)
}
root := doc.Content[0]
networks := mappingValue(root, "networks")
dokployNetwork := mappingValue(networks, "dokploy-network")
external := mappingValue(dokployNetwork, "external")
if external == nil || external.Kind != yaml.ScalarNode || external.Tag != "!!bool" || external.Value != "true" {
t.Fatalf("expected dokploy-network external to be bool true, got %#v in:\n%s", external, out)
}
}

func TestInlineComposeEnvFilesSanitizesCoolifyRuntimeCompose(t *testing.T) {
appDir := t.TempDir()
compose := `services:
Expand Down
Loading