TR-02-QF: quiet-flag header matches gate rows in TRUST-1/M5 receipt [host self-test PASS] - #231
Merged
Merged
Conversation
quiet_flag_present was sampled only when the receipt was written, while the QEMU gates check the flag when they are evaluated. A run with the flag up during the gates and down at write time produced "false" next to NOT_RUN "quiet flag" rows (TR-02 inspector, fix item 3). Now quiet_flag_present is true if the flag was up when any QEMU gate was evaluated, if any row was refused for it, or at write time. New fields quiet_flag_present_at_write and quiet_flag_refused_gates keep the raw samples. Self-test adds the mutation case (flag up at gates, down at write -> header must be true), a row-only case, and a never-up control. NOT_RUN: self-test not run by the builder; queued for the forge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aien-dev
added
host-only
aien-dev
changed the title
aien-dev
marked this pull request as ready for review
October 1, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/trust1_m5_qualify.shwrotequiet_flag_presentby sampling the quiet flag only when the receipt was written, while the QEMU gates check the flag when each gate is evaluated. A run with the flag up during the gates and down at write time produced a header sayingfalsenext to six NOT_RUN "quiet flag" rows (TR-02 inspector report, fix item 3).Change
evaluate_gaterecordsquiet_flag_seen_at_gates=truewhen it refuses a QEMU gate for the flag.write_receipt:quiet_flag_present(same field name) is now true if the flag was up at gate evaluation, OR any row is NOT_RUN with a "quiet flag" reason, OR the flag is up at write time.quiet_flag_present_at_write(the old write-time sample) andquiet_flag_refused_gates(count of rows refused for the flag).tpm2_getcap/tpm2_pcrreadlines untouched.Self-test mutation
New
--self-testcase: flag up while a QEMU gate is evaluated, removed beforewrite_receipt. Expected header:quiet_flag_present: true,quiet_flag_present_at_write: false,quiet_flag_refused_gates: 1. The old code writesfalsehere, so the case fails on the old behaviour and passes on the new. Also added: a row-only case (gate-time sample cleared, refused row still forcestrue) and a never-up control (false).Status
Host self-test PASS at 174ecbb (
bash scripts/trust1_m5_qualify.sh --self-test, log TR-02-QF-190053.log, ends TRUST1_M5_QUALIFY_SELF_TEST: PASS). QEMU NOT_RUN. Hardware NOT_RUN.Known limit (UNVERIFIED, medium confidence, from the inspector report): a child QEMU script refusal not worded "quiet flag" falls back to the write-time sample.
🤖 Generated with Claude Code