Add Support for File Upload with octetInputParser#78
Open
levirs565 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tRPC 11 support natively support uploading FIle (https://trpc.io/docs/server/non-json-content-types) using
octetInputParser. However when using this method, mutation can only upload 1 file and cannot add other key. Also, actuallyoctetInputParseris not valid Zod schema. When we callzodToJsonSchemato mutation input withoctetInputParse, this will cause error. Fotunately,octetInputParseris constant, when input definition is equal tooctetInputParser, we can assume the mutation accept a file as input. Currently, client validation not work on file input.