Update review-protocol dependency and tests (Closes #666) - #667
Open
octoaide[bot] wants to merge 1 commit into
Open
Update review-protocol dependency and tests (Closes #666)#667octoaide[bot] wants to merge 1 commit into
octoaide[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 81.92% 81.95% +0.02%
==========================================
Files 27 27
Lines 4261 4244 -17
==========================================
- Hits 3491 3478 -13
+ Misses 770 766 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #666
Summary
This PR updates the repository to follow upstream changes
introduced after review-protocol 0.19.0 by pinning the
dependency and updating tests that relied on the old API.
What changed
update Cargo.lock accordingly.
renamed agent_name in two tests.
Linux-only legacy reboot/shutdown tests now exercise the
public request::Handler API.
Files touched (high level)
Validation
revision that included the same API changes
Notes
be performed here due to blocked outbound GitHub access,
but the tests were adapted to the API surface changes
(agent_name rename and unary_request becoming private).
validation was performed on macOS where applicable.
If you want, I can open a follow-up to run CI on Linux
or adjust the tests further if CI surfaces any platform
specific failures.