Add a Markdown lint job - #91
Merged
Merged
Conversation
Nothing checked the Markdown here. `AGENTS.md` and `CLAUDE.md` were unlinted, and every sibling repository in the organization lints its own. Standalone rather than a step inside `check`, for two reasons: a clippy failure should not hide the Markdown result, and the lint should survive if the expensive jobs are ever put behind a path filter -- a docs-only change is exactly the change that needs it. No config file is added. Stock defaults pass as-is, verified against `main` with markdownlint-cli2 0.23.2, the version `@v24` pins: 0 issues across both files. A config can be added later if a rule proves too strict, rather than pre-emptively. Closes #90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90.
What was wrong
Nothing checked the Markdown in this repository.
AGENTS.mdandCLAUDE.mdwere unlinted, and every sibling repository in the organization —aicers/roxyd,aicers/agentcoop,aicers/bootroot,aicers/crusher,aicers/giganto, thereview-*repositories — lints its own.The change
A standalone
markdownjob (display nameMarkdown) with a recursive glob, matching the shapeaicers/roxydandaicers/agentcoopuse.Standalone rather than a step inside
check, for two reasons: a clippy failure should not hide the Markdown result, and the lint should survive if the expensive jobs are ever put behind a path filter — a docs-only change is exactly the change that needs it.No
.markdownlint-cli2.yamlis added. Stock defaults pass as-is; a config can be added later if a rule proves too strict, rather than pre-emptively.Verification
markdownlint-cli2@0.23.2— the version@v24pins — run recursively againstmainlocally reports 0 issues across both files with stock defaults.actionlint(with shellcheck) is clean.mainhas no branch protection, so no required-check change is needed.Relationship to the other open pull request
There is a separate pull request in this repository scoping the CI triggers. The two touch different parts of
ci.ymland were tested to merge cleanly in either order (git merge-tree, no conflict).Out of scope