Extract pull request conversion logic - #245
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 34.42% 40.69% +6.27%
==========================================
Files 17 17
Lines 1008 1118 +110
==========================================
+ Hits 347 455 +108
- Misses 661 663 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioCluml
left a comment
marioCluml
left a comment
There was a problem hiding this comment.
For src/database/pull_request.rs, it may be more intuitive to just import the paths in the use declaration block instead of using the path itself. What do you think? Same thing with src/outbound.rs, where tracing::warn! and tracing::debug! is used but tracing::error is declared in the use declaration block. I think it's minor but would be good in terms of consistency.
e.g. pull_requests::PullRequestsRepositoryPullRequestNodesAuthor vs on the top just adding it to use crate::outbound::pull_requests::{}
| // Labels and assignees | ||
| let labels = pr.labels.map(Vec::<String>::from).unwrap_or_default(); | ||
| let assignees = Vec::<String>::from(pr.assignees); | ||
| let review_requests = pr | ||
| .review_requests | ||
| .map(Vec::<String>::from) | ||
| .unwrap_or_default(); | ||
|
|
||
| // Comments require repository name context | ||
| let comments_total: i32 = pr.comments.total_count.try_into()?; | ||
| let repo_owner = pr.repository.owner.login.clone(); | ||
| let repo_name = pr.repository.name.clone(); | ||
| let comments_nodes = pr |
There was a problem hiding this comment.
For this, are the comments necessary?
There was a problem hiding this comment.
Removed the comments.
8f29507 to
312d86d
Compare
Applied the suggested adjustment. |
|
github-dashboard 진행을 stop 하므로, 리팩토링 목적의 이 PR은 리뷰/머지를 진행하는 것보다 정리하는 것이 효율적이라고 판단되어 닫습니다. |
3 participants
Closes #237