Take the changelog block and schedule the apply - #47
Merged
Conversation
Two gaps were left when the pin moved to a data file. Nothing here scheduled apply.yml, so this repository never proposed a release to itself; and repos.json upstream now lists changelog for deploy-core while the repository carried only workflow and rust. The second one cannot be delivered by the machinery that delivers everything else. render.py refuses a block whose marker pair is not already in the target, so the apply cannot bootstrap a block into a repository that has never had it -- the marker pair has to arrive by hand once, and so does the CHANGELOG.md the block is about. STYLE.md upstream asks the block to follow the file rather than lead it, and this is the file arriving. Landing it at the end state in one commit, because every intermediate is red: a marker pair the pin file does not list is a block this repository does not carry, a pin file listing changelog before the region is filled does not match the release, and either without CHANGELOG.md is a rule about a file that is not here. The regions were rewritten by apply_blocks.py against the 0.1.1 tree rather than by hand, so this is what the scheduled job would have written had it been able to. It moves the pin from v2 to 0.1.1 and drops the old v<N> from every BEGIN marker along the way. Closes #46
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46. Part of the consumer migration tracked in aicers/agent-instructions#16.
The pin file and the
with:-less drift job were already here. Two things were not: nothing scheduledapply.yml, andrepos.jsonupstream now listschangelogfordeploy-corewhile this repository carried onlyworkflowandrust.The second cannot be delivered by the machinery that delivers everything else.
render.pyrefuses a block whose marker pair is not already in the target, so the apply cannot bootstrap a block into a repository that has never had it. The marker pair arrives by hand once, and so does theCHANGELOG.mdthe block is about — upstreamSTYLE.mdasks the block to follow the file rather than lead it, and this is the file arriving.CHANGELOG.md— an empty skeleton with anUnreleasedheading.changelogmarker pair — after therustblock and before## This crate, matching the orderreview-protocoluses and keeping the shared regions contiguous.0.1.1applied over all three regions — including dropping the oldv<N>from every BEGIN marker, with the pin moved fromv2to0.1.1.update-instructions.yml— callsapply.ymlweekly, nowith:and nosecrets:, the same filereview-protocolcarries.One pull request, deliberately
Every intermediate state is red: a marker pair the pin file does not list is a block this repository does not carry; a pin file naming
changelogbefore the region is filled does not match the release; either one withoutCHANGELOG.mdis a rule about a file that is not here.The regions were not hand-edited
They were rewritten by
apply_blocks.pyagainst the0.1.1tree, so this is what the scheduled job would have written had it been able to. A dispatch after merging should find nothing to do.Checked locally
render.py checkreports all three regions current against0.1.1AGENTS.mdand the blocks listed in the pin file are the same three, so the drift check's other direction passes tooupdate-instructions.ymlparses; markdownlint clean onAGENTS.mdandCHANGELOG.md