Give every repository the changelog block - #25
Merged
Merged
Conversation
Five repositories -- bootler, multifold, roxyd, aice-web-next, aimer-web -- are gaining a CHANGELOG.md, so that every repository in the organization keeps one. repos.json withheld the changelog block from exactly those five, which would leave them holding the file with no shared rules for maintaining it. STYLE.md asks the block to follow the file rather than lead it; the file is arriving, so the block follows. Nothing reaches those five yet. None of them consumes anything -- no drift check, no pin file, no marker pairs -- and repos.json is intent, which has no effect on a repository until it is onboarded. What this must not do is get ahead of the file: onboarding one of them before its CHANGELOG.md merges would hand it rules for a file that is not there, which is what deploy-core hit. #22 orders that work. The changelog also gains what it should have had from the first release: an Unreleased heading and the link reference section every other repository here carries, so a reader can diff any two releases from the file rather than assembling compare URLs by hand. PATCH. A rule newly applying to a repository is MINOR, and below 1.0.0 the grades shift down one. Nothing in blocks/ changes -- which makes this the first release to depend on the guard fixed in #20, since comparing blocks/ alone would refuse it. Closes #24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
Five repositories —
bootler,multifold,roxyd,aice-web-next,aimer-web— are gaining aCHANGELOG.md(aicers/bootler#221, aicers/multifold#96, aicers/roxyd#52, aicers/aice-web-next#923, aicers/aimer-web#921), so every repository in the organization keeps one.repos.jsonwithheld thechangelogblock from exactly those five, which would leave them holding the file with no shared rules for maintaining it.STYLE.mdasks the block to follow the file rather than lead it, and the file is arriving.All twelve entries now include
changelog.This changes nothing downstream yet
None of the five consumes anything — no drift-check job, no pin file, no marker pairs.
repos.jsonis intent, and intent has no effect on a repository until it is onboarded.What it must not do is get ahead of the file. Onboarding one of them while it still has no
CHANGELOG.mdwould hand it rules for a file that is not there, which is whatdeploy-corehit. #22 orders that work; each repository'sCHANGELOG.mdhas to merge before its onboarding pull request opens.Changelog link section
The changelog also gains what it should have had from
0.1.0: an## [Unreleased]heading and the link reference section every other repository in the organization carries, so a reader can diff any two releases from the file instead of assembling compare URLs by hand.Grade
PATCH. A rule newly applying to a repository is MINOR, and below
1.0.0the grades shift down one. Nothing inblocks/changes — which makes0.1.2the first release to depend on the guard fixed in #20: comparingblocks/alone would refuse it.Test plan
changelog;repos.jsonparseslint_blocks.py,test_render.py,test_apply_blocks.py,test_release_surface.py,test_sync.py, markdownlint — all pass