Repository navigation
Declare prefer_pic_for_opt_binaries feature, disabled by default - #27
Merged
Merged
Conversation
Lets consumers opt in with --features=prefer_pic_for_opt_binaries so opt builds compile each source once (as PIC) instead of a .pic.o plus a non-PIC .o for static cc_binary links. Previously the flag was silently ignored because the toolchain didn't declare the feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gartnera
force-pushed
the
prefer-pic-for-opt-binaries
branch
from
October 7, 2026 19:38
1654a37 to
8a6b4d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets consumers opt in with --features=prefer_pic_for_opt_binaries so opt builds compile each source once (as PIC) instead of a .pic.o plus a non-PIC .o for static cc_binary links. Previously the flag was silently ignored because the toolchain didn't declare the feature.
We just need to declare this and
rules_ccdoes the rest.