feat: add translations#60
Draft
MyuddinKhatri wants to merge 6 commits into
Draft
Conversation
Collaborator
|
@MyuddinKhatri also add in docs |
MyuddinKhatri
marked this pull request as draft
July 2, 2024 05:57
Collaborator
Author
@Alchez Yes, I converted this to draft for now as it needs frappe environment in pre-commit context to run, Will have to look into it. |
agritheory
reviewed
Jul 30, 2024
agritheory
reviewed
Jul 30, 2024
|
|
||
|
|
||
| def add_translations(lang, app): | ||
| untranslated_file = "untranslated_strings" |
Owner
There was a problem hiding this comment.
@Alchez Suggests wrapping this entire function in a try/except that allows it to continue in the pre-commit context
Owner
|
@IshwaryaM1030 Please add the |
Owner
|
@IshwaryaM1030 Please rebase and mark ready when appropriate |
Collaborator
|
@agritheory The changes related to translations are already covered in #118 , So we can close this PR. Once you confirm I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #23