Bugfix: 349-2 console err - #353
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Three moderate issues remain around stale visibility updates, initial control state, and fallback timing.
Review effort: Lite
Findings: None
What changed in this PR
This pull request reduces premature ArcGIS tile-load errors during filter and map-scale initialization.
Changes:
- Initializes centroids with a
1=0filter. - Adds an unfiltered fallback when filter loading fails.
- Defers visibility updates until map scale settles.
| File | Summary |
|---|---|
src/mapLayers.ts |
Adds the initial no-match centroid filter. |
src/components/contexts/FilterProvider.tsx |
Adds filter-error fallback behavior; layer readiness may prevent the fallback from being applied. |
src/components/CentroidToggle.tsx |
Defers scale-based visibility changes; remaining effect dependencies and initial-state display need correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stdavis
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the "Failed to load tile" console errors, which are caused by race conditions. Tile renders were being kicked off before the proper filters had the chance to apply (fetched from Firebase) or when a stale filter was still applied (the very first centroid you click on, then hit Home).