Conversation
…elete entire shapes
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved critical extraction behavior and additional correctness and coverage issues remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
This PR fixes multipart geometry editing, sketch completion, duplicate map layers, and large shapefile extraction.
Changes:
- Improves multipart cutting and sketch synchronization.
- Adds layer cleanup and cancellation handling.
- Simplifies large extraction geometries and updates setup documentation.
| File | Summary |
|---|---|
src/components/MapContainer.tsx |
Adds cleanup and cancellation handling; stale navigation remains possible. |
src/components/FeatureGeometryEditor.tsx |
Improves sketch completion; normal drawings may remain in drawing state. |
src/components/addFeatureDraftGeometry.ts |
Handles multipart cuts. |
src/components/addFeatureDraftGeometry.test.ts |
Adds multipart and orientation coverage; one fixture is mislabeled. |
README.md |
Documents local setup. |
functions/src/handlers/extractions.ts |
Simplifies large query geometries; has filtering, multipoint, and test coverage issues. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stdavis
left a comment
There was a problem hiding this comment.
Nice work! There is some serious GIS stuff in here that you seemed to have no problem with. 👍
Just a few things...
I couldn't satisfy this requirement:
Can’t delete a single feature that is part of a multi-part feature. You have to delete the whole thing and re-upload/draw the parts that you want to keep. This is something you can do in the current app.
Maybe I'm missing something?
Addressed in most recent push. |
|
Geometry handling has been improved as discussed by @stdavis and I yesterday. I did look into |


Fix 1: Edit reversion bug.
Fix 2: Multi-create with checkmark press not saving bug.
Fix 3: Cut tool on multiple polygons fix.
Fix 4: Fix for error uploading large shapefiles.
Bonus fix: StrictMode duplicate layers