Skip to content

Fix/287 multipart features - #351

Open
acneville wants to merge 9 commits into
mainfrom
fix/287-multipart-features
Open

acneville wants to merge 9 commits into
mainfrom
fix/287-multipart-features

Conversation

@acneville

Copy link
Copy Markdown
Contributor

Fix 1: Edit reversion bug.
Fix 2: Multi-create with checkmark press not saving bug.
Fix 3: Cut tool on multiple polygons fix.
Fix 4: Fix for error uploading large shapefiles.
Bonus fix: StrictMode duplicate layers

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved critical extraction behavior and additional correctness and coverage issues remain.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

This PR fixes multipart geometry editing, sketch completion, duplicate map layers, and large shapefile extraction.

Changes:

  • Improves multipart cutting and sketch synchronization.
  • Adds layer cleanup and cancellation handling.
  • Simplifies large extraction geometries and updates setup documentation.
File Summary
src/​components/​MapContainer.tsx Adds cleanup and cancellation handling; stale navigation remains possible.
src/​components/​FeatureGeometryEditor.tsx Improves sketch completion; normal drawings may remain in drawing state.
src/​components/​addFeatureDraftGeometry.ts Handles multipart cuts.
src/​components/​addFeatureDraftGeometry.test.ts Adds multipart and orientation coverage; one fixture is mislabeled.
README.md Documents local setup.
functions/​src/​handlers/​extractions.ts Simplifies large query geometries; has filtering, multipoint, and test coverage issues.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread functions/src/handlers/extractions.ts Outdated
Comment thread src/components/MapContainer.tsx
@acneville
acneville requested a review from stdavis September 23, 2026 23:08

@stdavis stdavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! There is some serious GIS stuff in here that you seemed to have no problem with. 👍

Just a few things...

I couldn't satisfy this requirement:

Can’t delete a single feature that is part of a multi-part feature. You have to delete the whole thing and re-upload/draw the parts that you want to keep. This is something you can do in the current app.

Maybe I'm missing something?

Comment thread functions/src/handlers/extractions.ts Outdated
@acneville

Copy link
Copy Markdown
Contributor Author

Nice work! There is some serious GIS stuff in here that you seemed to have no problem with. 👍

Just a few things...

I couldn't satisfy this requirement:

Can’t delete a single feature that is part of a multi-part feature. You have to delete the whole thing and re-upload/draw the parts that you want to keep. This is something you can do in the current app.

Maybe I'm missing something?

Addressed in most recent push.

@acneville

Copy link
Copy Markdown
Contributor Author

Geometry handling has been improved as discussed by @stdavis and I yesterday. I did look into exceededTransferLimit but based on the codebase and git blame, Steve has already implemented it. Pushing shortly.

@acneville
acneville requested a review from stdavis September 25, 2026 20:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants