fix: Labels for points - #350
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing layer labeling patterns in the same file, and does not introduce any obvious runtime or typing issues.
Pull request overview
Adds client-side labeling configuration for the WRI Points FeatureLayer so point features display a “Project id” label when labels are enabled, aligning behavior with existing labeling on other WRI feature layers (e.g., lines/polygons) in src/mapLayers.ts.
Changes:
- Enable labels on the
pointsFeatureLayer (labelsVisible: true). - Add
labelingInfofor points with a text symbol and Arcade expression that labels byProject_ID.
File summaries
| File | Description |
|---|---|
src/mapLayers.ts |
Enables and configures point feature labels via labelsVisible + labelingInfo (text symbol + expression using Project_ID). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
acneville
enabled auto-merge (squash)
September 17, 2026 19:56
acneville
disabled auto-merge
September 17, 2026 19:56
acneville
enabled auto-merge (rebase)
September 17, 2026 19:56
stdavis
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding point labels. Works for single and multi-point setups.