Repository navigation
Implement detect-changes and other fixes - #30
Merged
Merged
Conversation
stdavis
enabled auto-merge (rebase)
August 27, 2026 22:31
stdavis
marked this pull request as draft
August 27, 2026 22:35
auto-merge was automatically disabled
August 27, 2026 22:35
Pull request was converted to draft
Trying to simplify and streamline here.
stdavis
force-pushed
the
feat/detects-feature-change
branch
from
August 27, 2026 23:00
3357d34 to
882d122
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new detect-changes CLI command to run ArcGIS Pro Detect Feature Changes against ETL output and publish results, while also tightening/standardizing CLI behaviors (outputs written to the input geodatabase) and expanding profile-driven ETL value-mapping support.
Changes:
- Added
utrans detect-changescommand with tests and README updates. - Standardized output workspace resolution via shared
get_output_workspace()and removed several CLI override flags foretlandget-recent-edits. - Reworked profiles to use explicit
value_mappings(and removed legacytranslate_vertical_levels), plus added a value-mapping discovery/apply script and CSV artifacts.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates workflow diagram to include detect-changes and revised CLI inputs/outputs. |
| cli/tests/test_recent_edits.py | Adds coverage for configured-field validation and profile schema change (no required_fields). |
| cli/tests/test_etl_mappers.py | Minor formatting adjustment to existing value-mapping normalization test. |
| cli/tests/test_detect_changes.py | Adds unit tests for detect-changes parsing, workspace resolution, DFC metadata, and append behavior. |
| cli/tests/test_cli.py | Registers detect-changes in CLI dispatch tests and updates help expectations for removed flags. |
| cli/src/utrans/utilities.py | Adds shared get_output_workspace() helper used by multiple commands. |
| cli/src/utrans/recent_edits.py | Removes several CLI/profile override knobs; adds configured-field validation and fixed output naming defaults. |
| cli/src/utrans/profiles.json | Adds/expands value_mappings across multiple counties; removes required_fields and legacy translation flags. |
| cli/src/utrans/etl.py | Removes --output-workspace/--output-name options; outputs now default to the source features’ geodatabase and a date-based name. |
| cli/src/utrans/etl_mappers.py | Removes translate_vertical_levels special-case logic in favor of profile value_mappings. |
| cli/src/utrans/detect_changes.py | New implementation of the detect-changes command (DFC run, metadata fields, filtered test output, append). |
| cli/src/utrans/cli.py | Wires detect-changes into the top-level CLI command router. |
| cli/scripts/value-mapping-summary.csv | Adds generated summary output for value-mapping discovery. |
| cli/scripts/value-mapping-inventory.csv | Adds generated inventory output for value-mapping discovery. |
| cli/scripts/reviewed-value-mappings.csv | Adds generated review worksheet output for value-mapping discovery. |
| cli/scripts/discover_value_mappings.py | Adds one-off discovery/apply script to generate inventory CSVs and merge reviewed mappings into profiles. |
| cli/scripts/county_datasets.csv | Adds a manifest of county datasets used by the discovery script. |
| cli/README.md | Documents new output-workspace behavior and the new detect-changes command. |
| cli/PROFILES.md | Updates profile documentation to reflect new detect-changes behavior and value_mappings usage. |
| add-in/UGRC.UtransTools/Config.daml | Bumps add-in version metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
stdavis
marked this pull request as ready for review
August 28, 2026 11:38
acneville
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.