Skip to content

Implement detect-changes and other fixes - #30

Merged
stdavis merged 14 commits into
mainfrom
feat/detects-feature-change
Aug 28, 2026
Merged

stdavis merged 14 commits into
mainfrom
feat/detects-feature-change

Conversation

@stdavis

@stdavis stdavis commented Aug 27, 2026

Copy link
Copy Markdown
Member

No description provided.

@stdavis
stdavis enabled auto-merge (rebase) August 27, 2026 22:31
@stdavis
stdavis marked this pull request as draft August 27, 2026 22:35
auto-merge was automatically disabled August 27, 2026 22:35

Pull request was converted to draft

@stdavis
stdavis force-pushed the feat/detects-feature-change branch from 3357d34 to 882d122 Compare August 27, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new detect-changes CLI command to run ArcGIS Pro Detect Feature Changes against ETL output and publish results, while also tightening/standardizing CLI behaviors (outputs written to the input geodatabase) and expanding profile-driven ETL value-mapping support.

Changes:

  • Added utrans detect-changes command with tests and README updates.
  • Standardized output workspace resolution via shared get_output_workspace() and removed several CLI override flags for etl and get-recent-edits.
  • Reworked profiles to use explicit value_mappings (and removed legacy translate_vertical_levels), plus added a value-mapping discovery/apply script and CSV artifacts.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
README.md Updates workflow diagram to include detect-changes and revised CLI inputs/outputs.
cli/tests/test_recent_edits.py Adds coverage for configured-field validation and profile schema change (no required_fields).
cli/tests/test_etl_mappers.py Minor formatting adjustment to existing value-mapping normalization test.
cli/tests/test_detect_changes.py Adds unit tests for detect-changes parsing, workspace resolution, DFC metadata, and append behavior.
cli/tests/test_cli.py Registers detect-changes in CLI dispatch tests and updates help expectations for removed flags.
cli/src/utrans/utilities.py Adds shared get_output_workspace() helper used by multiple commands.
cli/src/utrans/recent_edits.py Removes several CLI/profile override knobs; adds configured-field validation and fixed output naming defaults.
cli/src/utrans/profiles.json Adds/expands value_mappings across multiple counties; removes required_fields and legacy translation flags.
cli/src/utrans/etl.py Removes --output-workspace/--output-name options; outputs now default to the source features’ geodatabase and a date-based name.
cli/src/utrans/etl_mappers.py Removes translate_vertical_levels special-case logic in favor of profile value_mappings.
cli/src/utrans/detect_changes.py New implementation of the detect-changes command (DFC run, metadata fields, filtered test output, append).
cli/src/utrans/cli.py Wires detect-changes into the top-level CLI command router.
cli/scripts/value-mapping-summary.csv Adds generated summary output for value-mapping discovery.
cli/scripts/value-mapping-inventory.csv Adds generated inventory output for value-mapping discovery.
cli/scripts/reviewed-value-mappings.csv Adds generated review worksheet output for value-mapping discovery.
cli/scripts/discover_value_mappings.py Adds one-off discovery/apply script to generate inventory CSVs and merge reviewed mappings into profiles.
cli/scripts/county_datasets.csv Adds a manifest of county datasets used by the discovery script.
cli/README.md Documents new output-workspace behavior and the new detect-changes command.
cli/PROFILES.md Updates profile documentation to reflect new detect-changes behavior and value_mappings usage.
add-in/UGRC.UtransTools/Config.daml Bumps add-in version metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cli/src/utrans/cli.py
Comment thread cli/src/utrans/detect_changes.py Outdated
Comment thread cli/src/utrans/detect_changes.py Outdated
Comment thread cli/src/utrans/detect_changes.py
stdavis and others added 5 commits August 28, 2026 05:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@stdavis
stdavis marked this pull request as ready for review August 28, 2026 11:38
@stdavis
stdavis requested a review from acneville August 28, 2026 11:38
@stdavis
stdavis merged commit 3f66dee into main Aug 28, 2026
3 checks passed
@stdavis
stdavis deleted the feat/detects-feature-change branch August 28, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants