Add ChatMessageContent type to support image_url content#23
Open
mlang wants to merge 2 commits into
Open
Conversation
mlang
commented
Dec 12, 2023
mlang
commented
Contributor
- Add ChatMessageContent type to support image_url content
- Support the image_url detail parameter
nickhs
reviewed
Mar 23, 2024
| A.object [ "type" A..= ("image_url" :: T.Text), | ||
| "image_url" A..= case d of | ||
| Nothing -> A.String u | ||
| Just detail -> A.object [ "url" A..= u, |
Collaborator
There was a problem hiding this comment.
where did you find this? I don't see it in the API docs below but perhaps I'm looking in the wrong place?
Collaborator
There was a problem hiding this comment.
nevermind I found it! I needed to keep clicking the dropdowns - apologies!
Collaborator
There was a problem hiding this comment.
and from the vision guide it looks like its an enum of high, low, and auto. Thoughts on making it an enum?
| go xs' = A.Array . V.fromList $ map A.toJSON xs' | ||
|
|
||
| data ChatMessageContentPart = CMCP_Text T.Text | ||
| | CMCP_Image { imageUrl :: T.Text, imageDetail :: Maybe T.Text } |
Collaborator
There was a problem hiding this comment.
supernit: can be CMCPImageUrl?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.