Order actions groups by first call appearance in log#2
Open
cdlee2 wants to merge 1 commit intoagoulti:masterfrom
Open
Order actions groups by first call appearance in log#2cdlee2 wants to merge 1 commit intoagoulti:masterfrom
cdlee2 wants to merge 1 commit intoagoulti:masterfrom
Conversation
agoulti
added a commit
that referenced
this pull request
Oct 23, 2019
Remove printlog parameter --file and add a global parameter --grpc_log. This parameter will be used by other commands (e.g., ShowAction) if they will be looking up information from the log. Also refactor group by action functionality to be able to reuse in other places. Tested: manual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there ought to be some order to printing these log entries, and I think ordering them by first call log entry appearance is a reasonable choice. Assuming the log was dumped from Bazel, the order of the groups of calls should roughly be in the same order that the action started executing.