Repository navigation
fix(ci): give each dispatched release-images rebuild its own concurrency group - #2160
Merged
muscariello merged 1 commit intoOct 6, 2026
Conversation
…ncy group The concurrency group was keyed on github.ref, which is unique per tag for the tag-push trigger but identical -- the branch the workflow is read from -- for every workflow_dispatch run. Dispatching rebuilds for slim-v3.0.1, slim-control-plane-v3.0.1 and slim-channel-manager-v3.0.1 therefore put all three in one group: with cancel-in-progress false GitHub keeps one run and one pending run, so the third dispatch displaced the second and the control-plane rebuild was cancelled before it started. Key the group on the tag being built instead, falling back to github.ref for tag pushes. Signed-off-by: Luca Muscariello <muscariello@ieee.org>
msardara
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #2159, which added
workflow_dispatchtoci-release-images. Found while using it to rebuild the missing v3.0.1 images.The concurrency group is keyed on
github.ref:For the tag-push trigger that is unique per release, so each tag gets its own group. For
workflow_dispatchit is not: every dispatched run carries the ref of the branch the workflow is read from, so all of them land in a single group regardless of which tag they build.With
cancel-in-progress: false, GitHub keeps one run in progress and at most one pending; a further run displaces the pending one. Dispatching the three v3.0.1 rebuilds back to back therefore cancelled the middle one before it started:slim-v3.0.1slim-control-plane-v3.0.1slim-channel-manager-v3.0.1All three reported
head_branch=main, which is the collision.Fix
Key the group on the tag being built, falling back to
github.reffor tag pushes:Tag-push behaviour is unchanged. Dispatched rebuilds for different tags now run independently, while a repeat dispatch of the same tag still serialises, which is what you want when a rebuild is already pushing that tag.
Test plan
actionlintandzizmor --offlinecleanhead_branch=main