Skip to content

fix(auth): use ToSec1Point in wasm MLS key generation - #2154

Merged
janosSarusiKis merged 1 commit into
mainfrom
fix/auth-wasm-p256-sec1
Sep 30, 2026
Merged

fix(auth): use ToSec1Point in wasm MLS key generation#2154
janosSarusiKis merged 1 commit into
mainfrom
fix/auth-wasm-p256-sec1

Conversation

@janosSarusiKis

@janosSarusiKis janosSarusiKis commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

#2043 moved p256 to 0.14, where elliptic-curve deprecates ToEncodedPoint
and defines the SEC1 encoding methods on ToSec1Point. The native code
paths were updated, but the #[cfg(target_arch = "wasm32")] block in
generate_mls_signature_keys still imported ToEncodedPoint, so
agntcy-slim-auth has failed to compile for wasm32 since 2.3.3.

Verified locally (slim's wasm-test job does not compile agntcy-slim-auth for
wasm32: config depends on auth only on native targets):

  • cargo check -p agntcy-slim-bindings --target wasm32-unknown-unknown
    --no-default-features --features web: fails on main (E0599
    to_encoded_point), passes with this change
  • cargo clippy -p agntcy-slim-auth --target wasm32-unknown-unknown
    -- -D warnings: clean
  • native: clippy --all-targets -D warnings clean, 167 auth tests pass
  • end to end: agntcy/slim-bindings React Native generate:web (WASM
    release build, wasm-bindgen, tsc) passes against this branch

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@janosSarusiKis
fix(auth): use ToSec1Point in wasm MLS key generation
c0cdb8b 
Signed-off-by: Janos Sarusi-Kis <janossk@cisco.com>
@janosSarusiKis janosSarusiKis self-assigned this Sep 30, 2026
@janosSarusiKis
janosSarusiKis requested a review from a team as a code owner September 30, 2026 14:29
@janosSarusiKis
janosSarusiKis added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 25709c5 Sep 30, 2026
13 checks passed
@janosSarusiKis
janosSarusiKis deleted the fix/auth-wasm-p256-sec1 branch September 30, 2026 14:48
This was referenced Sep 30, 2026
Merged
Open
muscariello pushed a commit to vishalsahare/slim that referenced this pull request Oct 2, 2026
@build-agntcy
chore: release (agntcy#2153)
8a49425 
## 🤖 New release

* `agntcy-slim-auth`: 0.16.2 -> 0.16.3 (✓ API compatible changes)
* `agntcy-slim-config`: 0.16.4 -> 0.16.5
* `agntcy-slim-proto`: 0.6.4 -> 0.6.5
* `agntcy-slim-tracing`: 0.4.23 -> 0.4.24
* `agntcy-slim-datapath`: 0.19.1 -> 0.19.2
* `agntcy-slim-mls`: 0.4.1 -> 0.4.2
* `agntcy-slim-session`: 0.7.13 -> 0.7.14
* `agntcy-slim-controller`: 0.13.3 -> 0.13.4
* `agntcy-slim-service`: 0.13.1 -> 0.13.2
* `agntcy-slim`: 3.0.1 -> 3.0.2
* `agntcy-slim-channel-manager`: 3.0.1 -> 3.0.2
* `agntcy-slim-control-plane`: 3.0.1 -> 3.0.2
* `agntcy-slim-bindings`: 3.0.1 -> 3.0.2
* `agntcy-slim-rpc`: 3.0.1 -> 3.0.2
* `agntcy-slimctl`: 3.0.1 -> 3.0.2

<details><summary><i><b>Changelog</b></i></summary><p>

## `agntcy-slim-auth`

<blockquote>

##
[0.16.3](agntcy/slim@slim-auth-v0.16.2...slim-auth-v0.16.3)
- 2026-09-30

### Fixed

- *(auth)* use ToSec1Point in wasm MLS key generation
([agntcy#2154](agntcy#2154))
</blockquote>

## `agntcy-slim-config`

<blockquote>

##
[0.16.5](agntcy/slim@slim-config-v0.16.4...slim-config-v0.16.5)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth
</blockquote>

## `agntcy-slim-proto`

<blockquote>

##
[0.6.5](agntcy/slim@slim-proto-v0.6.4...slim-proto-v0.6.5)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-config
</blockquote>

## `agntcy-slim-tracing`

<blockquote>

##
[0.4.24](agntcy/slim@slim-tracing-v0.4.23...slim-tracing-v0.4.24)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-config
</blockquote>

## `agntcy-slim-datapath`

<blockquote>

##
[0.19.2](agntcy/slim@slim-datapath-v0.19.1...slim-datapath-v0.19.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-proto, agntcy-slim-tracing
</blockquote>

## `agntcy-slim-mls`

<blockquote>

##
[0.4.2](agntcy/slim@slim-mls-v0.4.1...slim-mls-v0.4.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth
</blockquote>

## `agntcy-slim-session`

<blockquote>

##
[0.7.14](agntcy/slim@slim-session-v0.7.13...slim-session-v0.7.14)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-datapath, agntcy-slim-mls
</blockquote>

## `agntcy-slim-controller`

<blockquote>

##
[0.13.4](agntcy/slim@slim-controller-v0.13.3...slim-controller-v0.13.4)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-proto, agntcy-slim-tracing,
agntcy-slim-datapath, agntcy-slim-session
</blockquote>

## `agntcy-slim-service`

<blockquote>

##
[0.13.2](agntcy/slim@slim-service-v0.13.1...slim-service-v0.13.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-datapath, agntcy-slim-mls,
agntcy-slim-session, agntcy-slim-controller
</blockquote>

## `agntcy-slim`

<blockquote>

##
[3.0.2](agntcy/slim@slim-v3.0.1...slim-v3.0.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-config,
agntcy-slim-tracing, agntcy-slim-service
</blockquote>

## `agntcy-slim-channel-manager`

<blockquote>

##
[3.0.2](agntcy/slim@slim-channel-manager-v3.0.1...slim-channel-manager-v3.0.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-proto, agntcy-slim-tracing,
agntcy-slim-datapath, agntcy-slim-session, agntcy-slim-service,
agntcy-slim
</blockquote>

## `agntcy-slim-control-plane`

<blockquote>

##
[3.0.2](agntcy/slim@slim-control-plane-v3.0.1...slim-control-plane-v3.0.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-proto, agntcy-slim-tracing,
agntcy-slim-datapath, agntcy-slim-service
</blockquote>

## `agntcy-slim-bindings`

<blockquote>

##
[3.0.2](agntcy/slim@slim-bindings-v3.0.1...slim-bindings-v3.0.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-tracing, agntcy-slim-datapath,
agntcy-slim-session, agntcy-slim-controller, agntcy-slim-service,
agntcy-slim
</blockquote>

## `agntcy-slim-rpc`

<blockquote>

##
[3.0.2](agntcy/slim@slim-rpc-v3.0.1...slim-rpc-v3.0.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-datapath, agntcy-slim-session,
agntcy-slim-service, agntcy-slim-bindings
</blockquote>

## `agntcy-slimctl`

<blockquote>

##
[3.0.2](agntcy/slim@slimctl-v3.0.1...slimctl-v3.0.2)
- 2026-09-30

### Other

- updated the following local packages: agntcy-slim-auth,
agntcy-slim-config, agntcy-slim-proto, agntcy-slim-tracing,
agntcy-slim-datapath, agntcy-slim-session, agntcy-slim-service,
agntcy-slim
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msardara msardara msardara approved these changes

Assignees

@janosSarusiKis janosSarusiKis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janosSarusiKis @msardara