[db] Do in place shrinking of values in Storage #1783

[michaelvlach]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agdb	Ready	Preview, Comment	May 2, 2026 7:28am

[Copilot]

Pull request overview

This PR updates the core Storage shrinking logic to support in-place value shrink when enough space can be reclaimed, and adds regression tests to ensure storage layout/reading remains correct after shrinking.

Changes:

• Update Storage::shrink_value to optionally write an “empty record” into reclaimed space instead of always moving the record to the end.
• Add Storage::write_empty helper to persist an empty record header.
• Add tests for in-place shrinking behavior in MemoryStorage and reload/readability behavior in FileStorage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
agdb/src/storage.rs	Implements in-place shrinking by writing an empty record into reclaimed space.
agdb/src/storage/memory_storage.rs	Adds tests covering in-place shrink behavior, truncation-at-end, and compaction via optimize_storage().
agdb/src/storage/file_storage.rs	Adds a persistence/reload test to ensure storages with holes remain readable.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.