[api] Remove TypeDefImpl derive #1793

[michaelvlach]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agdb	Ready	Preview, Comment	May 1, 2026 7:19pm

[Copilot]

Pull request overview

Removes the redundant TypeDefImpl derive macro from the API surface and migrates all in-repo call sites to use #[derive(agdb::TypeDef)], keeping the type-definition reflection system consistent across crates.

Changes:

• Replaced #[derive(agdb::TypeDefImpl)] with #[derive(agdb::TypeDef)] across server, API, core types, and queries.
• Removed the TypeDefImpl proc-macro derive from agdb_derive.
• Updated agdb’s api re-exports to stop exporting TypeDefImpl.

Reviewed changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
agdb_server/src/routes/db/user.rs	Switches request param derive from TypeDefImpl to TypeDef.
agdb_server/src/routes/db.rs	Switches several query param derives from TypeDefImpl to TypeDef.
agdb_server/src/routes/admin/db.rs	Switches admin request derive from TypeDefImpl to TypeDef.
agdb_server/src/routes/admin.rs	Switches log-level request derive from TypeDefImpl to TypeDef.
agdb_derive/src/lib.rs	Removes TypeDefImpl proc-macro derive; keeps TypeDef.
agdb_api/rust/src/test_server/test_error.rs	Updates conditional API derive to TypeDef.
agdb_api/rust/src/api_types/config_impl.rs	Updates conditional API derive to TypeDef.
agdb_api/rust/src/api_types.rs	Updates multiple conditional API derives to TypeDef.
agdb_api/rust/src/api_error.rs	Updates conditional API derive to TypeDef.
agdb/tests/api_def_reflection_test.rs	Updates reflection tests to use TypeDef.
agdb/src/type_def/trait_def.rs	Updates internal type-def model derive to TypeDef.
agdb/src/type_def/struct_def.rs	Updates internal type-def model derive + tests to TypeDef.
agdb/src/type_def/impl_def.rs	Updates internal type-def model derive + tests to TypeDef.
agdb/src/type_def/function_def.rs	Updates internal type-def model derive to TypeDef.
agdb/src/type_def/expression_def.rs	Updates internal type-def model derives to TypeDef.
agdb/src/type_def/enum_def.rs	Updates internal type-def model derive + tests to TypeDef.
agdb/src/type_def.rs	Updates core type-def AST derives to TypeDef.
agdb/src/query/select_values_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_node_count.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_keys_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_key_count_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_indexes_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_edge_count_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_all_aliases_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/select_aliases_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/search_query.rs	Updates conditional API derives to TypeDef.
agdb/src/query/remove_values_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/remove_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/remove_index_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/remove_aliases_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/query_values.rs	Updates conditional API derives to TypeDef.
agdb/src/query/query_result.rs	Updates conditional API derive to TypeDef.
agdb/src/query/query_ids.rs	Updates conditional API derive to TypeDef.
agdb/src/query/query_id.rs	Updates conditional API derive to TypeDef.
agdb/src/query/query_condition.rs	Updates conditional API derives to TypeDef.
agdb/src/query/query_aliases.rs	Updates conditional API derive to TypeDef.
agdb/src/query/insert_values_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/insert_nodes_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/insert_index_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/insert_edges_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query/insert_aliases_query.rs	Updates conditional API derive to TypeDef.
agdb/src/query.rs	Updates conditional API derive to TypeDef.
agdb/src/lib.rs	Removes TypeDefImpl from api re-export list.
agdb/src/db/db_value.rs	Updates conditional API derives to TypeDef.
agdb/src/db/db_key_value.rs	Updates conditional API derive to TypeDef.
agdb/src/db/db_key_order.rs	Updates conditional API derives to TypeDef.
agdb/src/db/db_id.rs	Updates conditional API derive to TypeDef.
agdb/src/db/db_f64.rs	Updates conditional API derive to TypeDef.
agdb/src/db/db_element.rs	Updates conditional API derive to TypeDef.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.