[api] Support sequence expression parsing #1786#1789
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for parsing Rust range (.. / ..=) expressions into AgDB’s type definition reflection AST so functions annotated with #[agdb::fn_def] can represent ranges in their captured expression bodies.
Changes:
- Extend
agdb_deriveexpression parsing to handlesyn::Expr::Rangeand emitExpression::Range. - Add
Expression::Range { start, end, inclusive }to the publicExpressionenum inagdb. - Add unit tests validating several range forms are reflected correctly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
agdb_derive/src/type_def_parser/expression_parser.rs |
Parses syn::ExprRange and emits a new Expression::Range node with optional bounds and inclusivity. |
agdb/src/type_def/expression_def.rs |
Adds the new Expression::Range variant and tests for range reflection output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/agnesoft/agdb/sessions/f919e44b-3d63-4bd6-b9c7-d751a0936833 Co-authored-by: michaelvlach <11575751+michaelvlach@users.noreply.github.com>
agnesoft
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.