[server] Fix inconsistent handling of base path in studio #1782#1788
Merged
michaelvlach merged 5 commits intomainfrom May 1, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes inconsistent base-path handling by centralizing server URL construction and applying it consistently across Studio asset rewriting, OpenAPI server metadata, logging, and cluster node identification.
Changes:
- Introduce
ConfigImpl::server_url()and use it for Studio URL replacement and OpenAPI server configuration. - Normalize
basepathinput (ensure leading/) and strip any path component fromaddress(with a warning). - Initialize tracing earlier with an
Infodefault and reload to configured log level after config is read.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
agdb_server/src/routes/studio.rs |
Use config.server_url() when rewriting Studio’s localhost URL. |
agdb_server/src/main.rs |
Initialize tracing before config load; log server URL via server_url(). |
agdb_server/src/config.rs |
Add server_url(), normalize basepath, strip path from address, and use server URL for cluster node id selection. |
agdb_server/src/cluster.rs |
Determine local cluster index using config.server_url(). |
agdb_server/src/app.rs |
Use server_url() for OpenAPI server URL (avoid manual concatenation). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agnesoft
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.