[api] List the API type defs #1778#1779
Merged
michaelvlach merged 2 commits intomainfrom Apr 25, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “API catalog” of type definitions for the Rust agdb_api crate and updates trait type-def generation to produce TypeDefinition implementors that can be enumerated.
Changes:
- Update
#[agdb::trait_def]expansion to emit a*Defmarker struct implementingTypeDefinition(instead of a__*_type_def()free function). - Introduce
agdb_api::api::Api::type_defs()to return a curated list of(Type, Vec<Impl>)for the public API surface, with tests validating closure/type-graph resolvability and catalog completeness. - Add/adjust feature-gated exports to make required type/trait defs accessible under the
apifeature.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| agdb_derive/src/type_def_parser/trait_parser.rs | Changes trait macro output to generate a *Def struct implementing TypeDefinition. |
| agdb_api/rust/src/lib.rs | Feature-gates the new api module and re-exports generated *Def marker types. |
| agdb_api/rust/src/api.rs | Adds the API type-def catalog and graph validation tests. |
| agdb/tests/api_def_reflection_test.rs | Updates tests to use *Def::type_def() instead of __*_type_def(). |
| agdb/src/type_def/trait_def.rs | Updates internal trait-def tests for the new *Def::type_def() access pattern. |
| agdb/src/lib.rs | Feature-gated re-exports of additional API-relevant types to support catalog construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/agnesoft/agdb/sessions/ad8527f5-9af4-4165-9b92-eec2176e1b01 Co-authored-by: michaelvlach <11575751+michaelvlach@users.noreply.github.com>
agnesoft
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.