Skip to content

chore: remove sync-catalog-context workflow (catalog-context opens the sync PR) - #42

Merged
rogiervanstraten merged 1 commit into
mainfrom
claude/sharp-dijkstra-lnqrx5
Sep 17, 2026
Merged

rogiervanstraten merged 1 commit into
mainfrom
claude/sharp-dijkstra-lnqrx5

Conversation

@rogiervanstraten

@rogiervanstraten rogiervanstraten commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

What

Removes .github/workflows/sync-catalog-context.yml from this repo.

Why

This repo is public. GitHub does not let a public repository resolve the private shinetools/github-actions action, so the weekly sync workflow here failed on every run with Unable to resolve action shinetools/github-actions, not found (and installing the organization-shine-modules-read app did not change that, as verified after applying it).

Rather than keep a broken workflow in a public repo, the sync is inverted: catalog-context (internal, already has working GCP auth) opens the sync PR into this repo on each of its releases. See the companion PRs:

  • ageras-com/catalog-context — new sync-schema-collection.yml workflow that runs the sync and opens the PR here.
  • ageras-com/tf-github — installs the shine-release-please app on this repo so that workflow's token can open PRs here.

scripts/sync-catalog-context.mjs stays in this repo: it encodes this repo's file layout, and the catalog-context workflow invokes it against a checkout of this repo.

Ordering

Merge this only after the catalog-context workflow and the tf-github app install are in place, so the sync path is never absent.

🤖 Generated with Claude Code

https://claude.ai/code/session_017TGVgYdpN5p9b1BDvvuwsy


Generated by Claude Code


Note

Medium Risk
Operational risk if merged before the replacement sync path exists; no runtime schema or application code changes in this PR.

Overview
Removes the .github/workflows/sync-catalog-context.yml workflow that used to run on a weekly schedule (and via dispatch) to pull *.schema.json from catalog-context releases, run scripts/sync-catalog-context.mjs, and open an automated sync PR here.

The workflow depended on private shinetools/github-actions GCP auth, which cannot run in this public repo, so it was failing every run. Sync is inverted: the internal catalog-context repo now runs the sync and opens PRs into this repo on release (companion changes elsewhere). scripts/sync-catalog-context.mjs is unchanged and remains the layout-specific sync entrypoint for that external workflow.

Merge order matters: this should land only after the catalog-context workflow and GitHub app install are live, so automated enum/schema sync is not interrupted.

Reviewed by Cursor Bugbot for commit 3530a04. Bugbot is set up for automated code reviews on this repo. Configure here.

@rogiervanstraten
rogiervanstraten marked this pull request as ready for review September 17, 2026 11:30
@rogiervanstraten
rogiervanstraten requested a review from a team as a code owner September 17, 2026 11:30

@clook clook left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, didn't realize it broke the sync!

@rogiervanstraten
rogiervanstraten merged commit 99222da into main Sep 17, 2026
1 check passed
@rogiervanstraten
rogiervanstraten deleted the claude/sharp-dijkstra-lnqrx5 branch September 17, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants