chore: remove sync-catalog-context workflow (catalog-context opens the sync PR) - #42
Merged
Merged
Conversation
rogiervanstraten
marked this pull request as ready for review
September 17, 2026 11:30
rogiervanstraten
enabled auto-merge
September 17, 2026 11:30
clook
approved these changes
Sep 17, 2026
clook
left a comment
There was a problem hiding this comment.
Thanks, didn't realize it broke the sync!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
.github/workflows/sync-catalog-context.ymlfrom this repo.Why
This repo is public. GitHub does not let a public repository resolve the private
shinetools/github-actionsaction, so the weekly sync workflow here failed on every run withUnable to resolve action shinetools/github-actions, not found(and installing theorganization-shine-modules-readapp did not change that, as verified after applying it).Rather than keep a broken workflow in a public repo, the sync is inverted:
catalog-context(internal, already has working GCP auth) opens the sync PR into this repo on each of its releases. See the companion PRs:ageras-com/catalog-context— newsync-schema-collection.ymlworkflow that runs the sync and opens the PR here.ageras-com/tf-github— installs theshine-release-pleaseapp on this repo so that workflow's token can open PRs here.scripts/sync-catalog-context.mjsstays in this repo: it encodes this repo's file layout, and the catalog-context workflow invokes it against a checkout of this repo.Ordering
Merge this only after the catalog-context workflow and the tf-github app install are in place, so the sync path is never absent.
🤖 Generated with Claude Code
https://claude.ai/code/session_017TGVgYdpN5p9b1BDvvuwsy
Generated by Claude Code
Note
Medium Risk
Operational risk if merged before the replacement sync path exists; no runtime schema or application code changes in this PR.
Overview
Removes the
.github/workflows/sync-catalog-context.ymlworkflow that used to run on a weekly schedule (and via dispatch) to pull*.schema.jsonfromcatalog-contextreleases, runscripts/sync-catalog-context.mjs, and open an automated sync PR here.The workflow depended on private
shinetools/github-actionsGCP auth, which cannot run in this public repo, so it was failing every run. Sync is inverted: the internalcatalog-contextrepo now runs the sync and opens PRs into this repo on release (companion changes elsewhere).scripts/sync-catalog-context.mjsis unchanged and remains the layout-specific sync entrypoint for that external workflow.Merge order matters: this should land only after the catalog-context workflow and GitHub app install are live, so automated enum/schema sync is not interrupted.
Reviewed by Cursor Bugbot for commit 3530a04. Bugbot is set up for automated code reviews on this repo. Configure here.