Skip to content

Conversation

@robindiddams
Copy link
Member

@robindiddams robindiddams commented Jan 21, 2026

Summary by CodeRabbit

  • New Features
    • Enhanced session establishment to include instance type and instance tags metadata, enabling improved session tracking and management capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

The SessionHello protocol buffer message in gravity/proto/gravity_session.proto has been extended with two new fields: instance_type (string) and instance_tags (repeated string). These fields capture additional instance metadata during session establishment. A comment describing the region field was also modified.

Changes

Cohort / File(s) Summary
Protocol Buffer Session Message
gravity/proto/gravity_session.proto
Added two new fields to SessionHello message: instance_type (tag 10) and instance_tags (tag 11) for transmitting instance metadata. Updated comment on region field description.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


🧹 Recent nitpick comments
gravity/proto/gravity_session.proto (1)

100-101: LGTM! Consider map<string, string> for tags if key-value semantics are needed.

The new fields are backward compatible and field numbering is correct. One design consideration: cloud provider tags (AWS, GCP, Azure) are typically key-value pairs. If you need to preserve the key-value structure for querying or filtering, a map<string, string> might be more appropriate:

map<string, string> instance_tags = 11;

If the tags are intentionally flat labels or you're using a key=value string encoding, the current repeated string approach is fine.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54d06d9 and 722e21d.

⛔ Files ignored due to path filters (1)
  • gravity/proto/gravity_session.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (1)
  • gravity/proto/gravity_session.proto
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (go)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@robindiddams robindiddams merged commit e359630 into main Jan 21, 2026
5 checks passed
@robindiddams robindiddams deleted the more-provider-info branch January 21, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants