(WIP) Feature/signals#48
Draft
mp-orkes wants to merge 6 commits into
Draft
Conversation
…ent factory methods
…isposition, implicit, merge)
…entries to Python SDK
Server:
- AgentService.signal(): per-workflow lock, 100 lifetime / 10 pending limits,
Conductor updateVariables queue, urgent pause/resume, propagation to sub-workflows
- AgentController: POST /{id}/signal, POST /signal (broadcast), GET /signal/{id}/status
- AgentEventListener: urgent pause detection, signal SSE event emission from dispositions
- AgentCompiler: init 7 signal workflow vars, wire intake/merge/implicit task pairs into loop
- ToolCompiler: signal tool routing in enrichment JS, buildSignalIntakeTasks/MergeTasks/ImplicitAcceptTasks
- AgentChatCompleteTaskMapper: inject _signal_injection messages + ephemeral tools before LLM call
- JavaScriptBuilder: signalIntakeScript, signalDispositionScript, implicitAcceptScript, signalStateMergeScript
Python SDK:
- AgentRuntime: signal(), broadcast(), get_signal_status(), signal_async()
- AgentHandle/AgentStream: signal() convenience methods
- Agent: signal_mode parameter (evaluate | auto_accept | disabled)
- signal_tool(): define tools that trigger signals on running agents
- SSE parsing: signal_received, signal_accepted, signal_rejected event types
- AgentEvent.data field for structured signal payloads
- Example: 09e_signals.py
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
WorkflowExecutor.updateVariables() does not exist in Conductor 3.3.0.rc4.
Replace both call sites with a REST POST to Conductor's built-in
/workflow/{id}/variables endpoint using java.net.http.HttpClient,
following the same pattern used by ListApiToolsTask.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- AgentEventListener: add @lazy to WorkflowExecutor injection to break circular dependency with WorkflowExecutorOps at startup - AgentChatCompleteTaskMapper: use List<ToolSpec> (not List<Object>) and convert signal tool maps to ToolSpec instances - AgentService: disambiguate searchWorkflows() overload with (String) null cast - AgentCompilerTest: find loop tasks by type/name instead of fixed index 0, since signal intake tasks now precede LLM/callbacks in the loop body - AgentEventListenerTest: remove verify on workflowExecutor.updateVariables() (now done via REST); verify pauseWorkflow() only - AgentServiceSignalTest: fix constructor arg order and add missing ProviderValidator mock - JavaScriptBuilderSignalTest: fix assertion to match actual script content Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bradyyie
reviewed
May 12, 2026
bradyyie
left a comment
bradyyie
left a comment
Collaborator
There was a problem hiding this comment.
QA review: This PR has merge conflicts and is marked WIP. The signals feature touches both Python SDK (signal.py, result.py, tool.py) and Java server (AgentCompiler, ToolCompiler, AgentController, JavaScriptBuilder). Recommend: resolve conflicts or close if the feature approach has changed since April 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.