feat(skill): add PR review skill with per-repo context support#262
Open
vishesh-orkes wants to merge 5 commits into
Open
feat(skill): add PR review skill with per-repo context support#262vishesh-orkes wants to merge 5 commits into
vishesh-orkes wants to merge 5 commits into
Conversation
Adds a fully self-contained pr-reviewer skill that runs on every PR via GitHub Actions. Reviews against 8 criteria (Logic, Quality, Security, Scope, Tests, Performance, Error Handling, Observability) using a single token-bounded bundle call instead of multiple round-trips. Key design decisions: - get_pr_review_bundle: scores + selects top 4 highest-risk files, compact diffs capped at 16k chars total (vs 400k+ in naive approach) - Hard tool budget of 2 calls (bundle + optional grep for verification) - Per-repo context via .agentspan/pr-review-context.md — injected into every bundle so the agent knows repo-specific patterns and gotchas - ADDED file detection: inline warning prevents agent from grepping brand-new files that don't exist on disk yet - Execution limits (max_turns, max_tokens, timeout_seconds) now flow correctly from Python Agent → serialized config → Java SkillNormalizer
v1r3n
reviewed
May 21, 2026
|
|
||
| raw_config = agent_obj._framework_config | ||
| raw_config = dict(agent_obj._framework_config) | ||
| raw_config["maxTurns"] = getattr(agent_obj, "max_turns", 25) |
Contributor
There was a problem hiding this comment.
this should not be here or part of this PR
v1r3n
requested changes
May 21, 2026
v1r3n
left a comment
v1r3n
left a comment
Contributor
There was a problem hiding this comment.
the example change should not have any changes to the core sdk
Author
okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fully self-contained pr-reviewer skill that runs on every PR via GitHub Actions. Reviews against 8 criteria (Logic, Quality, Security, Scope, Tests, Performance, Error Handling, Observability) using a single token-bounded bundle call instead of multiple round-trips.
Key design decisions: