Skip to content

style: format code using spotless#822

Merged
AlbumenJ merged 2 commits intoagentscope-ai:mainfrom
LearningGp:style
Feb 25, 2026
Merged

style: format code using spotless#822
AlbumenJ merged 2 commits intoagentscope-ai:mainfrom
LearningGp:style

Conversation

@LearningGp
Copy link
Collaborator

AgentScope-Java Version

1.0.10

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

Change-Id: Ida48ae55b37f9fe4a4072b43eb95b9ff2b2cea79
@LearningGp LearningGp requested review from a team and Copilot February 25, 2026 03:27
@gemini-code-assist
Copy link

Summary of Changes

Hello @LearningGp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality and maintainability by applying automated code formatting. The changes ensure that the project adheres to a consistent style guide, making the codebase easier to read and understand for all contributors.

Highlights

  • Code Formatting: Applied the spotless code formatter to enforce consistent style and improve readability across the codebase.
Changelog
  • agentscope-core/src/main/java/io/agentscope/core/tool/mcp/McpClientBuilder.java
    • Reformatted the constructor call for McpSchema.Implementation to improve line wrapping and readability.
  • agentscope-core/src/test/java/io/agentscope/core/VersionTest.java
    • Adjusted line breaks within the Assertions.assertEquals call for better formatting.
Activity
  • The author has completed the pre-review checklist, confirming that the code has been formatted with mvn spotless:apply, all tests are passing, Javadoc comments are complete, and related documentation has been updated.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies code formatting using spotless. The changes are mostly stylistic. I've found one area for improvement where a hardcoded version string can be replaced with the existing Version.VERSION constant to improve maintainability. Please see my specific comment for details.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Formats existing Java code with Spotless to align with the repository’s style rules (no functional changes intended), improving readability and keeping CI/style checks consistent.

Changes:

  • Reflowed a long JUnit assertion in VersionTest to Spotless multi-line formatting.
  • Reflowed the McpSchema.Implementation constructor call in McpClientBuilder to Spotless multi-line formatting.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
agentscope-core/src/test/java/io/agentscope/core/VersionTest.java Reformats a long assertEquals call for Spotless compliance.
agentscope-core/src/main/java/io/agentscope/core/tool/mcp/McpClientBuilder.java Reformats a long McpSchema.Implementation constructor invocation for Spotless compliance.

Change-Id: I3312aba853c9b3bd9acd37c0edc3349aa30dd4bf
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit 0a4eb61 into agentscope-ai:main Feb 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants