style: format code using spotless#822
Conversation
Change-Id: Ida48ae55b37f9fe4a4072b43eb95b9ff2b2cea79
Summary of ChangesHello @LearningGp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code quality and maintainability by applying automated code formatting. The changes ensure that the project adheres to a consistent style guide, making the codebase easier to read and understand for all contributors. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request applies code formatting using spotless. The changes are mostly stylistic. I've found one area for improvement where a hardcoded version string can be replaced with the existing Version.VERSION constant to improve maintainability. Please see my specific comment for details.
agentscope-core/src/main/java/io/agentscope/core/tool/mcp/McpClientBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Formats existing Java code with Spotless to align with the repository’s style rules (no functional changes intended), improving readability and keeping CI/style checks consistent.
Changes:
- Reflowed a long JUnit assertion in
VersionTestto Spotless multi-line formatting. - Reflowed the
McpSchema.Implementationconstructor call inMcpClientBuilderto Spotless multi-line formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentscope-core/src/test/java/io/agentscope/core/VersionTest.java | Reformats a long assertEquals call for Spotless compliance. |
| agentscope-core/src/main/java/io/agentscope/core/tool/mcp/McpClientBuilder.java | Reformats a long McpSchema.Implementation constructor invocation for Spotless compliance. |
agentscope-core/src/main/java/io/agentscope/core/tool/mcp/McpClientBuilder.java
Outdated
Show resolved
Hide resolved
Change-Id: I3312aba853c9b3bd9acd37c0edc3349aa30dd4bf
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AgentScope-Java Version
1.0.10
Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)