Skip to content

Fix/temporal close preserve workflows - #58

Merged
vinodvx merged 2 commits into
mainfrom
fix/temporal-close-preserve-workflows
Jul 28, 2026
Merged

Fix/temporal close preserve workflows#58
vinodvx merged 2 commits into
mainfrom
fix/temporal-close-preserve-workflows

Conversation

@vinodvx

@vinodvx vinodvx commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

  • Stop terminating active Temporal workflows on Agent.Close / runtime Close so runs stay durable across worker/agent restarts
  • Update docs (Close / Temporal durability) and Agent Chat reference-app page to match
  • Fix Close unit tests to assert workflows are not terminated

Test plan

  • go test ./internal/runtime/temporal/ -run Close_Active
  • Restart agent/worker mid-run and confirm workflow continues in Temporal UI

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor / chore

Related issues

Checklist

  • I have run task check
  • I have run task examples:all
  • I have run task tidy if I added or removed dependencies
  • Commit messages follow conventional commits (e.g. feat:, fix:, docs:)
  • I have added/updated tests for my changes
  • Documentation is updated if needed

@mintlify

mintlify Bot commented Jul 28, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
agent-sdk-go 🟢 Ready View Preview Jul 28, 2026, 7:58 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@vinodvx
vinodvx merged commit a3cd804 into main Jul 28, 2026
5 checks passed
@vinodvx
vinodvx deleted the fix/temporal-close-preserve-workflows branch July 28, 2026 08:06
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mintlify

mintlify Bot commented Jul 28, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
agent-sdk-go 🟡 Building Jul 28, 2026, 7:57 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant