fix(temporal): unblock Get/Events on run timeout and terminate workflows on close - #57
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Get/Eventswhen a run hitsWithTimeoutor Stream/Run deadline (no per-call waiter deadlines required); emit a clear timeout error instead of hanging.Close(parallel terminate with reasonagent closed).Get/Events/ reconnect ctx cancel as waiter-only; run cancel stays on Stream/Run ctx,WithTimeout, or explicitCancel().AgentStream.Approve(deprecatesAgent.OnApproval); update docs and durable_agent scenario notes.Test plan
go test ./internal/runtime/temporal/ ./pkg/agent/context deadline exceeded(no hang / latecanceled)WithTimeout: Events onBackgroundstill gets terminal timeout errorClosewith active runs: workflows terminate; process exits within Close timeoutType of change
Related issues
Checklist
task checktask examples:alltask tidyif I added or removed dependenciesfeat:,fix:,docs:)