[notme-18450e] fix(ci): run the publish gate's tests from worker/, not the root#44
Merged
Merged
Conversation
…t the root Second publish attempt failed: ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL, Command "vitest" not found. vitest is a devDependency of the worker package only — the repo root has none. `pnpm vitest` at the root resolves fine LOCALLY through hoisting, which is exactly why this passed every local check and failed in a clean CI install. Local success was evidence about my node_modules, not about the workflow. worker's vitest config globs ../packages/dpop/__tests__, so running the suite from worker/ covers the SDK's own 67 tests AND proves worker still resolves the package through its bare specifier — a stronger gate than testing the package in isolation. Both failures so far have been caught by the gate BEFORE the publish step, which is the design working: an npm version is immutable once it lands, so failing early costs a re-tag and nothing else. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second publish attempt failed:
ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "vitest" not found.vitestis a devDependency of the worker package only — the repo root has none.pnpm vitestat the root resolves fine locally through hoisting, which is exactly why this passed every local check and failed in a clean CI install. Local success was evidence about mynode_modules, not about the workflow.worker's vitest config globs
../packages/dpop/__tests__, so running the suite fromworker/covers the SDK's own 67 tests and proves worker still resolves the package through its bare specifier — a stronger gate than testing the package in isolation.Verified:
cd worker && pnpm vitest run→ 23 files / 339 pass;pnpm --filter @agentic-research/dpop build→ exit 0.Both failures so far were caught before the publish step, which is the design working — an npm version is immutable once it lands, so failing early costs a re-tag and nothing else.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UNahXs8dda3vttpWrVwVaA