Skip to content

fix(ci): remove ripgrep dependency from clear-room gate #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuluo-yx merged 2 commits into from
Oct 24, 2026
Merged

fix(ci): remove ripgrep dependency from clear-room gate #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0da4027
fix(ci): remove ripgrep dependency from clear-room gate
yuluo-yx Oct 24, 2026
d3af6d0
fix(ci): update zod to patched release
yuluo-yx Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions argi-studio/agent-chat-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"tailwindcss-animate": "^1.0.7",
"use-stick-to-bottom": "^1.0.46",
"uuid": "^11.1.1",
"zod": "^3.24.2"
"zod": "^4.6.7"
},
"devDependencies": {
"@eslint/js": "^9.19.0",
Expand Down Expand Up @@ -104,7 +104,9 @@
"source-map-js": "^1.2.2",
"tar": "^7.5.22",
"uuid": "^11.1.1",
"ws": "^8.20.1"
"ws": "^8.20.1",
"zod": "^4.6.7",
"zod-to-json-schema": "^3.25.2"
},
"pnpm": {
"overrides": {
Expand All @@ -130,7 +132,9 @@
"source-map-js": "1.2.2",
"tar": "7.5.22",
"uuid": "11.1.1",
"ws": "8.20.1"
"ws": "8.20.1",
"zod": "4.6.7",
"zod-to-json-schema": "3.25.2"
}
},
"packageManager": "pnpm@10.5.1"
Expand Down
82 changes: 37 additions & 45 deletions argi-studio/agent-chat-ui/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 18 additions & 16 deletions tools/scripts/verify-clear-room.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,28 +36,30 @@ grep -q '<artifactId>argi-workflow-graph-core</artifactId>' "${REPO_ROOT}/argi-o
for module in argi-agent/argi-agent-api argi-agent/argi-agent-core \
argi-orchestration/argi-workflow-core argi-runtime/argi-runtime-api \
argi-runtime/argi-runtime-core; do
if rg -n 'argi-workflow-graph-core' "${REPO_ROOT}/${module}/pom.xml"; then
if grep -n 'argi-workflow-graph-core' "${REPO_ROOT}/${module}/pom.xml"; then
fail "${module} must not depend on Workflow Graph Core"
fi
done

legacy_production_refs="$(rg -l 'argi-graph-core' "${REPO_ROOT}" \
--glob '!AGENTS.md' \
--glob '!docs/**' \
--glob '!argi-orchestration/argi-workflow-graph-core/README.md' \
--glob '!argi-orchestration/argi-workflow-graph-core/src/test/**' \
--glob '!benchmark/**' \
--glob '!example/**' \
--glob '!tools/scripts/verify-clear-room.sh' \
--glob '!**/target/**' \
--glob '!**/.flattened-pom.xml' || true)"
legacy_production_refs="$(git -C "${REPO_ROOT}" grep -l 'argi-graph-core' -- \
. \
':(exclude)AGENTS.md' \
':(exclude)docs/**' \
':(exclude)argi-orchestration/argi-workflow-graph-core/README.md' \
':(exclude)argi-orchestration/argi-workflow-graph-core/src/test/**' \
':(exclude)benchmark/**' \
':(exclude)example/**' \
':(exclude)tools/scripts/verify-clear-room.sh' \
':(exclude)**/target/**' \
':(exclude)**/.flattened-pom.xml' || true)"
[[ -z "${legacy_production_refs}" ]] || fail "legacy artifact references remain:${legacy_production_refs}"

rg -q 'GRAPH\("graph"\)' "${REPO_ROOT}/argi-runtime/argi-runtime-api/src/main/java" \
git -C "${REPO_ROOT}" grep -q 'GRAPH("graph")' -- argi-runtime/argi-runtime-api/src/main/java \
|| fail "DefinitionKind.GRAPH wire name is not preserved"
rg -q 'graphId|graphVersion' "${REPO_ROOT}/argi-runtime/argi-runtime-core/src/main/java" \
git -C "${REPO_ROOT}" grep -q -E 'graphId|graphVersion' -- argi-runtime/argi-runtime-core/src/main/java \
|| fail "graph definition identifiers are not documented in runtime code"
rg -q 'ARGI_CHAT_MESSAGE|LegacyChatRecordSupport' "${REPO_ROOT}/argi-orchestration/argi-workflow-graph-core/src/main" \
git -C "${REPO_ROOT}" grep -q -E 'ARGI_CHAT_MESSAGE|LegacyChatRecordSupport' \
-- argi-orchestration/argi-workflow-graph-core/src/main \
|| fail "Loop serializer compatibility boundary is missing"

for document in clear-room-baseline.md checkpoint-compatibility.md api-boundaries.md; do
Expand All @@ -66,12 +68,12 @@ for document in clear-room-baseline.md checkpoint-compatibility.md api-boundarie
done

if [[ -d "${REPO_ROOT}/benchmark" ]]; then
if rg -n 'argi-graph-core' "${REPO_ROOT}/benchmark" --glob '*.xml' --glob '!**/target/**'; then
if grep -R -n --include='*.xml' --exclude-dir=target 'argi-graph-core' "${REPO_ROOT}/benchmark"; then
fail "benchmark submodule still references argi-graph-core"
fi
fi
if [[ -d "${REPO_ROOT}/example" ]]; then
if rg -n 'argi-graph-core' "${REPO_ROOT}/example" --glob '*.xml' --glob '!**/target/**'; then
if grep -R -n --include='*.xml' --exclude-dir=target 'argi-graph-core' "${REPO_ROOT}/example"; then
fail "example submodule still references argi-graph-core"
fi
fi
Expand Down
Loading