fix(examples): declare local SDK workspace deps#222
Merged
Conversation
The SDK imports agent_control_telemetry at module load. Wheel builds vendor telemetry into the SDK package, so PyPI installs work. Examples that override agent-control-sdk with a workspace path source bypass that vendoring and need telemetry declared as a separate workspace package, otherwise importing the SDK fails with ModuleNotFoundError. Add agent-control-telemetry to the affected example pyprojects (deps and uv source path).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
abhinav-galileo
changed the title
namrataghadi-galileo
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix example projects that install
agent-control-sdkfrom the local workspace path.Published SDK wheels bundle the SDK's internal sibling packages where appropriate, but local path installs bypass that wheel bundling. These examples therefore need to declare the sibling workspace packages they import through the SDK.
Changes
agent-control-telemetryto examples that already use localagent-control-sdkpath sources.examples/strands_agentsconsistent with the other local SDK examples by declaring the localagent-control-engine,agent-control-evaluators,agent-control-models, andagent-control-telemetrysources.Verification
git diff --checkexamples/strands_agents:uv run python -c "import agent_control; from agent_control_telemetry.trace_context import TraceContext; print('ok')"