Skip to content

fix(ui): fix editing of controls in the UI#218

Merged
avalencia-galileo merged 1 commit into
mainfrom
fix-ui
May 11, 2026
Merged

fix(ui): fix editing of controls in the UI#218
avalencia-galileo merged 1 commit into
mainfrom
fix-ui

Conversation

@namrataghadi-galileo
Copy link
Copy Markdown
Contributor

##Summary##
Fixed edit-control modal crashes for template-backed controls that may not include template_values or rendered fields.
The UI now routes any control with template metadata to the template editor instead of falling through to the raw control editor.

##Scope##
User-facing/API changes: Fixes “Something went wrong” when editing sparse/unrendered template controls.
Internal changes: Added defensive template normalization and a regression fixture/test.

Out of scope: Backend API behavior changes.

##Risk and Rollout##
Risk level: low
Rollback plan: Revert the UI changes in the template edit/control edit files and test fixtures.

##Testing##
Added or updated automated tests
Ran make check (not run; UI-only change. Ran targeted UI checks instead.)
Manually verified behavior

Ran:

make ui-typecheck
make ui-lint
make ui-build
Note: Playwright integration tests could not run because local Chromium is missing.

##Checklist##
Linked issue/spec (if applicable)
Updated docs/examples for user-facing changes
Included any required follow-up tasks: install Playwright browsers and run the focused integration test.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@avalencia-galileo avalencia-galileo merged commit 981e33d into main May 11, 2026
6 checks passed
@avalencia-galileo avalencia-galileo deleted the fix-ui branch May 11, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants