Skip to content

feat: Support ACP additional directories#191

Merged
benbrandt merged 4 commits into
mainfrom
additional-directories
Jun 16, 2026
Merged

feat: Support ACP additional directories#191
benbrandt merged 4 commits into
mainfrom
additional-directories

Conversation

@benbrandt

Copy link
Copy Markdown
Member

No description provided.

@AlexandrSuhinin AlexandrSuhinin self-requested a review June 15, 2026 06:39
@AlexandrSuhinin

Copy link
Copy Markdown
Collaborator

Essentially we only populate write permissions to these additional roots? Do we expect that agent will know that it can/should work in these directories from the prompt?
I'm not sure what problem we solve here.

Comment thread src/CodexAcpClient.ts Outdated
@benbrandt benbrandt force-pushed the additional-directories branch from 15c84f3 to 466cc8f Compare June 15, 2026 13:17
@benbrandt

Copy link
Copy Markdown
Member Author

The goal is to support the same behavior as --add-dir in the codex CLI which allows you to have a session with multiple directories. We allow for multi-directory projects in zed, so this allows us to pass them all in to the session

@benbrandt benbrandt marked this pull request as draft June 16, 2026 11:19
@benbrandt benbrandt force-pushed the additional-directories branch from 504b87d to deac985 Compare June 16, 2026 11:30
@benbrandt benbrandt marked this pull request as ready for review June 16, 2026 11:52
@benbrandt benbrandt merged commit 27fb950 into main Jun 16, 2026
4 checks passed
@benbrandt benbrandt deleted the additional-directories branch June 16, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants